Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The contrast() filter does not deal with premultiplied alpha correctly #1854

Closed
mstange opened this issue Oct 12, 2017 · 4 comments
Closed

The contrast() filter does not deal with premultiplied alpha correctly #1854

mstange opened this issue Oct 12, 2017 · 4 comments
Labels
bugzilled type: bug

Comments

@mstange
Copy link
Contributor

mstange commented Oct 12, 2017

Testcase and more detailed description coming tomorrow.
@mstange
Copy link
Contributor Author

mstange commented Oct 12, 2017 •
edited

https://bugzilla.mozilla.org/show_bug.cgi?id=1408116

Testcase

Expected vs. actual rendering:
screen shot 2017-10-12 at 2 39 36 pm

I think it's worth making all color transform filters work the same: unpremultiply, apply a matrix, premultiply. Here's the Gecko code that computes the color matrix for the different filter types: http://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/gfx/src/FilterSupport.cpp#396-513

@Darkspirit
Copy link
Sponsor

This got fixed with the latest webrender update. (8a39cf2...d490a74)
https://bugzilla.mozilla.org/show_bug.cgi?id=1408116#c2

@glennw
Copy link
Member

glennw commented Nov 19, 2017

Thanks!

@glennw glennw closed this as completed Nov 19, 2017
@mstange
Copy link
Contributor Author

mstange commented Nov 20, 2017

This was fixed by #2048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilled type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvark @mstange @glennw @Darkspirit