Update CODEOWNERS to use darwin-maintainers team #30341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets up the Darwin-maintainers team as CODEOWNERS for Darwin paths. So anyone in that team will get notified (instead of just listing individuals). /cc @org/darwin-maintainers
matthewbauer
commented
Oct 12, 2017
| pkgs/os-specific/darwin/* @LnL7 | ||
| pkgs/os-specific/darwin/apple-source-releases/* @copumpkin | ||
| /pkgs/stdenv/darwin/ @org/darwin-maintainers | ||
| /pkgs/os-specific/darwin/ @org/darwin-maintainers |
There was a problem hiding this comment.
/ will include all subdirs and files AFAICT
fpletz
approved these changes
Oct 13, 2017
domenkozar
approved these changes
Oct 13, 2017
LnL7
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the Darwin-maintainers team as CODEOWNERS for Darwin paths. So anyone in that team will get notified (instead of just listing individuals).
/cc @org/darwin-maintainers
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)