New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcl: qt4 -> qt5; 1.8.0 -> 1.8.1 #30342
Conversation
The Travis CI build failures are due to exceeding the time limit. |
The way Qt5 dependencies are specified is different from Qt4.
|
Thanks for the great feedback, @peterhoeg! I've made the changes you suggested, and had the extremely welcome surprise of those changes not changing the hash of the package, so I don't have to wait for another multi-hour build! 🙌 |
|
||
src = fetchFromGitHub { | ||
owner = "PointCloudLibrary"; | ||
repo = "pcl"; | ||
rev = name; | ||
sha256 = "1pki4y7mc2dryxc8wa7rs4hg74qab80rpy90jnw3j8fzf09kxcll"; | ||
sha256 = "05wvqqi2fyk5innw4mg356r71c1hmc9alc7xkf4g81ds3b3867xq"; | ||
}; | ||
|
||
enableParallelBuilding = true; | ||
|
||
nativeBuildInputs = [ pkgconfig ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake should also go into nativeBuildInputs.
I will strongly recommend working against |
I work off of |
Still works for me, so I hope we're good to go. |
I'll try building it on NixOS. |
If you'd like to try building something that uses PCL to ensure that the GUI components work, here is a test application they provide in their docs that I have packaged for nix for my own testing. |
Thanks! |
Motivation for this change
Get pcl building on darwin.
Drop the qt4 dependency as it is rotting.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)