Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sphinx_guzzle_theme #30334

Merged
merged 3 commits into from Oct 12, 2017
Merged

add sphinx_guzzle_theme #30334

merged 3 commits into from Oct 12, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 11, 2017

Motivation for this change

This adds sphinx_guzzle_theme, which is used for sphinx documentation in various projects, including BorgBackup. This could also be used for #30287.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
maintainers: add flokli
18d617c
@flokli
sphinx_guzzle_theme: init at 0.7.11
f304963 
This adds sphinx_guzzle_theme, which is used for sphinx documentation in
various projects, including BorgBackup.
@flokli flokli mentioned this pull request Oct 11, 2017
Merged
8 tasks
FRidh
FRidh reviewed Oct 12, 2017
View reviewed changes
pkgs/development/python-modules/guzzle_sphinx_theme/default.nix Outdated
version = "0.7.11";
name = "sphinx_guzzle_theme-${version}";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use fetchPypi instead

FRidh
FRidh reviewed Oct 12, 2017
View reviewed changes
pkgs/development/python-modules/guzzle_sphinx_theme/default.nix Outdated

doCheck = false; # no tests

buildInputs = [ sphinx ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propagatedBuildInputs

@Mic92 Mic92 merged commit ab2cc75 into NixOS:master Oct 12, 2017
indiscipline added a commit to indiscipline/nixpkgs that referenced this pull request Oct 12, 2017
@indiscipline
Change required documentation theme to sphinx_guzzle_theme from NixOS…
a63ebf6 
…#30334
@flokli flokli deleted the sphinx_guzzle_theme branch October 12, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @FRidh @Mic92 @Janik-Haag