Changed error thrown by Dir.entries method from ENOENT to ENOTDIR #4814
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is now consistent with MRI.
kares
reviewed
Oct 12, 2017
| @@ -44,7 +44,7 @@ def test_seek | |||
| end | |||
|
|
|||
| def test_nodir | |||
| assert_raise(Errno::ENOENT) { Dir.open(@nodir) } | |||
| assert_raise(Errno::ENOTDIR) { Dir.open(@nodir) } | |||
There was a problem hiding this comment.
guess, these hasn't been imported for a while.
could you please confirm the test is updated at MRI's for Ruby 2.3 / 2.4 ?
There was a problem hiding this comment.
I checked this test all the way up to current MRI trunk and it is still ENOENT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it is now consistent with MRI.
Resolves #3840.