Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jb #30345

Merged
merged 6 commits into from Oct 14, 2017
Merged

Update jb #30345

merged 6 commits into from Oct 14, 2017

Conversation

matklad
Copy link
Member

@matklad matklad commented Oct 12, 2017

Motivation for this change

Update jetbrains products & jdk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (tested that intellij idea works with updated jdk)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matklad matklad requested a review from edwtjo as a code owner October 12, 2017 08:49
@Mic92
Copy link
Member

Mic92 commented Oct 12, 2017 •
edited

Can split the update commit? I might need to backport some of the updates.

@matklad
Copy link
Member Author

matklad commented Oct 12, 2017

@Mic92 sure, done!

@Mic92 Mic92 merged commit a062e32 into NixOS:master Oct 14, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 14, 2017

Thanks!

@matklad matklad mentioned this pull request Nov 15, 2017
Merged
8 tasks
@matklad matklad deleted the update-jb branch April 6, 2018 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matklad @Mic92