darwin: fix assorted xcbuild builds #30338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copumpkin
commented
Oct 12, 2017
| @@ -188,6 +188,22 @@ let | |||
| Type = "ProductType"; | |||
| Name = "Dynamic Library"; | |||
| PackageTypes = [ "com.apple.package-type.mach-o-dylib" ]; | |||
| DefaultBuildProperties = { | |||
There was a problem hiding this comment.
Without this it seems to try to compile my libutil dylib as an executable and complains about a missing _main symbol.
|
We’re you able to look at network_cmds? I think libipsec is available from apple. |
|
Haven't tried making a build for it yet, nope. |
|
@matthewbauer looks like the |
matthewbauer
approved these changes
Oct 12, 2017
This includes adding a new xcbuild-based libutil build to test the waters a bit there. We'll need to get xcbuild into the stdenv bootstrap before we can make the main build, but it's nice to see that it can work.
copumpkin
force-pushed
the
xcbuild-fixes
branch
from
b0f8670
to
e86991e
Compare
|
Whoops, realized I'd forgotten libutil/new.nix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes adding a new xcbuild-based libutil build to test the waters a bit there. We'll need to get xcbuild into the stdenv bootstrap before we can make the main build, but it's nice to see that it can work.
cc @matthewbauer @LnL7