Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rp hang #2913

Merged
merged 2 commits into from Sep 23, 2017
Merged

Fix rp hang #2913

merged 2 commits into from Sep 23, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Sep 22, 2017

This makes sure that exceptions thrown during the creation of the resource_partitioner don't cause hangs at startup.

This also adds a fallback to get_num_cores() for systems which don't report a proper value from hwloc.

@hkaiser hkaiser added this to the 1.1.0 milestone Sep 22, 2017
sithhell
sithhell approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaiser hkaiser merged commit 95a3e7d into master Sep 23, 2017
@hkaiser hkaiser deleted the fix_rp_hang branch September 23, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: resource_partitioner type: enhancement
Projects
resource partitioner/manager work
completed
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell