Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oraclejdk: add version 9 #29693

Merged
merged 1 commit into from Sep 26, 2017
Merged

oraclejdk: add version 9 #29693

merged 1 commit into from Sep 26, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 23, 2017

Motivation for this change

See the releaes notes.

Oracle JDK 9 does not seems to contain jre directory, so oraclejre9 package now uses a dedicated archive file.

There is no 32-bit version nor arm version yet. So I didn't make oraclejdk9 the default version for oraclejdk package. If Oracle releases them, I will update the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sample code for testing: https://github.com/taku0/JavaSample


Oracle JDK 9 does not seems to contain jre directory, so oraclejre9
package now uses a dedicated archive file.

There is no 32-bit version nor arm version (yet). If Oracle releases
them, I will update the package.
@NeQuissimus
Copy link
Member

LGTM, ran a quick test:

λ ./result/bin/jshell
Sep 26, 2017 10:24:18 AM java.util.prefs.FileSystemPreferences$1 run
INFO: Created user preferences directory.
|  Welcome to JShell -- Version 9
|  For an introduction type: /help intro
jshell> System.getProperties()
$1 ==> {awt.toolkit=sun.awt.X11.XToolkit, java.specification.version=9, file.encoding.pkg=sun.io, sun.cpu.isalist=, sun.jnu.encoding=UTF-8, java.class.path=., java.vm.vendor=Oracle Corporation, sun.arch.data.model=64, java.vendor.url=http://java.oracle.com/, user.timezone=, os.name=Linux, java.vm.specification.version=9, sun.java.launcher=SUN_STANDARD, user.country=CA, sun.boot.library.path=/nix/store/ipjf3qapyhxgmd4gjp94r2yjz08zmrpr-oraclejdk-9/lib, sun.java.command=jdk.jshell.execution.RemoteExecutionControl 39571, jdk.debug=release, sun.cpu.endian=little, user.home=/home/nix, user.language=en, java.specification.vendor=Oracle Corporation, java.home=/nix/stor ... chine Specification, java.awt.printerjob=sun.print.PSPrinterJob, sun.os.patch.level=unknown, java.library.path=/run/opengl-driver/lib:/usr/java/packages/lib:/usr/lib64:/lib64:/lib:/usr/lib, java.vm.info=mixed mode, java.vendor=Oracle Corporation, java.vm.version=9+181, sun.io.unicode.encoding=UnicodeLittle, java.class.version=53.0}

@NeQuissimus NeQuissimus merged commit b482460 into NixOS:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants