Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually display multitouch emulation if sim set to True. #5396

Merged
merged 1 commit into from Sep 24, 2017

Conversation

matham
Copy link
Member

@matham matham commented Sep 23, 2017

It didn't display it when the sim profile was set to True, even though it should have. Instead it never displayed the sim touch.

@KeyWeeUsr
Copy link
Contributor

@matham do you have any simple example/instructions to test it with?

@matham
Copy link
Member Author

matham commented Sep 23, 2017

Yeah, set multitouch on demand in config and then right click in a normal widget vs scatter. Previously it would never show the red dot (but would still emulate it so it'd be invisible), now it does it for scatter only.

@KeyWeeUsr
Copy link
Contributor

Reproduced, feel free to merge. I'm trying to create a simple unittest for that. :)

@KeyWeeUsr
Copy link
Contributor

I wonder why is it a different behavior for on_demand simulator and the default one i.e. why the default one works correctly right after pressing and the on_demand only after releasing? Shouldn't they match?

@matham
Copy link
Member Author

matham commented Sep 24, 2017

The default is verrrrry greedy and always puts the dot. With on_demand, at the time of press we don't know whether it'll be a mulittouch sim touch, so we wait until release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants