nodePackages.typings: init at 2.1.1 #29687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92, @svanderburg and @mt-caret to be potential reviewers. |
|
I would also like to get this into 17.09 if possible. How should I do that, given that the process of adding a new node package also updates others? |
|
Backporting would probably requiring backporting all other commits with did to nodePackages ... this is kind of a mess. Is having your own package.json with just |
|
Yeah, that's what we've gone with for now. Thanks for helping me think this through. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm introducing Nix at my workplace, in part as a replacement for Homebrew, as well as to manage development environments. For now,
typingsis still part of our workflow.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)