Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singular: use gcc5 to fix build #29682

Closed
wants to merge 1 commit into from
Closed

singular: use gcc5 to fix build #29682

wants to merge 1 commit into from

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Sep 22, 2017

Motivation for this change

#28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm added this to the 17.09 milestone Sep 22, 2017
@7c6f434c 7c6f434c closed this in f7d7c7b Sep 23, 2017
@7c6f434c
Copy link
Member

Thanks for checking that this approach works.

globin pushed a commit that referenced this pull request Sep 23, 2017
@7c6f434c @globin
singular: use gcc5
5cf35d7 
Progress on: #28643
Fixes: #29682

(cherry picked from commit f7d7c7b)
@womfoo
Copy link
Member Author

womfoo commented Sep 23, 2017

No prob!

@womfoo womfoo deleted the fix/singular-build branch September 23, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@womfoo @7c6f434c @joachifm