Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11: generate nvidia_icd.json from template #29790

Merged
merged 1 commit into from Sep 26, 2017
Merged

nvidia-x11: generate nvidia_icd.json from template #29790

merged 1 commit into from Sep 26, 2017

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Sep 25, 2017

Motivation for this change

Vulkan applications stopped running as nvidia started shipping a template for nvidia_icd.json instead of the final file. This makes them work again (tested with vulkaninfo and sascha willems's vulkan examples).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jansol
Copy link
Contributor Author

jansol commented Sep 26, 2017

cc @grahamc @fpletz @globin

Cherry-picking this into 17.09 would probably be a good idea too.

@fpletz fpletz merged commit 4ec3d31 into NixOS:master Sep 26, 2017
@fpletz
Copy link
Member

fpletz commented Sep 26, 2017

And cherry-picked: c7842d0

@fpletz fpletz added this to the 17.09 milestone Sep 26, 2017
@fpletz fpletz added the 0.kind: regression Something that worked before working no longer label Sep 26, 2017
@jansol jansol mentioned this pull request Oct 1, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jansol @fpletz