Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-node-exporter: 0.14.0 -> 0.15.0 #30535

Merged
merged 2 commits into from Oct 22, 2017
Merged

prometheus-node-exporter: 0.14.0 -> 0.15.0 #30535

merged 2 commits into from Oct 22, 2017

Conversation

bachp
Copy link
Member

@bachp bachp commented Oct 18, 2017

Motivation for this change

https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md#v0150--2017-10-06

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Oct 18, 2017

This will need changes to the module, too.

@bachp
Copy link
Member Author

bachp commented Oct 18, 2017

@globin You are right. I will have a look at it and update the PR.

@bachp
prometheus-node-exporter service: update for new arguments handling
b6ab05e 
The behaviour have changed again. Listed collectors are now enabled in
addition to the default one.

Also run as DynmicUser instead of user nobody as the exporter doesn't need
any state.
@bachp
Copy link
Member Author

bachp commented Oct 20, 2017

@globin The module is updated too.

@bachp
Copy link
Member Author

bachp commented Oct 21, 2017

@joachifm It is no longer WIP

@globin globin merged commit 0f0f0cb into NixOS:master Oct 22, 2017
@fpletz
Copy link
Member

fpletz commented Oct 25, 2017

Using DynamicUser breaks the systemd and logind collectors. I've reverted this change to use the nobody user again for now: 63bbada

fpletz added a commit that referenced this pull request Oct 25, 2017
@fpletz
prometheus-node-exporter service: run as nobody again
63bbada 
Using DynamicUser breaks the systemd and logind collectors.

cc #30535
fpletz added a commit that referenced this pull request Oct 25, 2017
@fpletz
prometheus-node-exporter service: run as nobody again
0dd0578 
Using DynamicUser breaks the systemd and logind collectors.

cc #30535

(cherry picked from commit 63bbada)
@fpletz
Copy link
Member

fpletz commented Oct 25, 2017

This is the error:

time="2017-10-25T15:56:05Z" level=error msg="ERROR: logind collector failed after 0.001064s: unable to connect to dbus: dbus: authentication failed" source="collector.go:123"
time="2017-10-25T15:56:05Z" level=error msg="ERROR: systemd collector failed after 0.001223s: couldn't get units states: couldn't get dbus connection: dbus: authentication failed" source="collector.go:123"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @globin @fpletz @joachifm