-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitea: init at 1.2.1 #30528
gitea: init at 1.2.1 #30528
Conversation
Could gitea share NixOS module with gogs? If we had "services.gogs.package = gogs|gitea"? |
It's a possibility at this point, but I'd be wary the further the fork diverges, the more things would be different. In this particular case, the systemd pre-start script needed to copy some locales over into the state directory to get the service to run. I also don't think upstream has any intention on keeping compatibility with gogs going forward. |
config = mkIf cfg.enable { | ||
|
||
systemd.services.gitea = { | ||
description = "gitea (Gitea Service)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bikeshed: "Gitea self-hosted Git Service"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gitea should be enough according to https://github.com/NixOS/nixpkgs/pull/28851/files#r136598912
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
description = "Gitea Service"; | ||
home = cfg.stateDir; | ||
createHome = true; | ||
shell = pkgs.bash; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this user need a shell? (I don't think I've seen that option being used for daemon users before.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, copied the old module. This is gone and it still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
hello fellow nixtronauts, I opened a gitea PR a while ago: #28851 just wanted to let you know. |
Motivation for this change
adds gitea package and service module
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)