Regex: support duplicated named captures #5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makenowjust
force-pushed
the
feature/regexp/duplicated-named-capture
branch
from
a8a3f63
to
d7dcfee
Compare
makenowjust
force-pushed
the
feature/regexp/duplicated-named-capture
branch
from
d7dcfee
to
84725bd
Compare
|
Current crystal compiler cannot compile regexp containing duplicated named captures, so CI is failed. Should I replace regexp literal to |
makenowjust
changed the title
|
I should fix this document also. |
|
#5061 (comment) I want some opinion to this. /cc @asterite @mverzilli @RX14 |
|
Yeah, using |
|
@RX14 fixed this. |
RX14
approved these changes
Oct 7, 2017
asterite
reviewed
Oct 13, 2017
src/regex/match_data.cr
Outdated
| private def named_capture_number(group_name) | ||
| first = Pointer(UInt8).null | ||
| last = Pointer(UInt8).null | ||
| name_entry_size = LibPCRE.get_stringtable_entries(@code, group_name, pointerof(first), pointerof(last)) |
There was a problem hiding this comment.
can out first, out last be used here?
asterite
approved these changes
Oct 13, 2017
oprypin
reviewed
Oct 13, 2017
src/regex/match_data.cr
Outdated
| @@ -157,10 +157,24 @@ class Regex | |||
| # "Crystal".match(/r(?<ok>ys)/).not_nil!["ok"]? # => "ys" | |||
| # "Crystal".match(/r(?<ok>ys)/).not_nil!["ng"]? # => nil | |||
| # ``` | |||
| # | |||
| # When there are capture groups having same name, it returns the lastest | |||
There was a problem hiding this comment.
Should be "last". There is another place where this should be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cannot use duplicated named captures by default:
But we can use
(?J)for this:Unfortunately,
Regex::MatchDatadoes not support duplicated named captures, so this code is broken:This PR fixes
Regex::MatchDatato support duplicated named captures, andRegexpaccepts duplicated named captures by default. Duplicated named captures are useful when writing complex regexp. Thank you.