Skip to content

Commit

Permalink
Item14493: Remove dependency on quote= option
Browse files Browse the repository at this point in the history
GroupViewTemplate is the only place in the distribution that uses the
quote= option on the ICON macro.  Removing it, so that JQICON can be
easily substituted for ICON.
  • Loading branch information
gac410 committed Sep 30, 2017
1 parent 58ae72c commit e29ba86
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions core/data/System/GroupViewTemplate.txt
@@ -1,4 +1,4 @@
%META:TOPICINFO{author="ProjectContributor" date="1495729065" format="1.1" version="1"}%
%META:TOPICINFO{author="ProjectContributor" date="1506735457" format="1.1" version="1"}%
%{ NOTE: THIS IS A SKIN TEMPLATE, NOT A TOPIC TEMPLATE }%
%TMPL:INCLUDE{"view"}%

Expand Down Expand Up @@ -164,16 +164,16 @@ div.wikiGroupsAction {
then='
---++ %MAKETEXT{"Administration"}%
'}%
%ICON{"useradd" quote="\""}% <a href='%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_add;groupname=%groupname%' alt='%MAKETEXT{"Add members..."}%' title='%MAKETEXT{"Add members..."}%' class='jqUIDialogLink {cache:false}'>%MAKETEXT{"Add members..."}%</a>
%ICON{"useradd"}% <a href='%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_add;groupname=%groupname%' alt='%MAKETEXT{"Add members..."}%' title='%MAKETEXT{"Add members..."}%' class='jqUIDialogLink {cache:false}'>%MAKETEXT{"Add members..."}%</a>
%IF{"$allowremove"
then='%BR%%ICON{"userdelete" quote="\""}% <a href="%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_remove;groupname=%groupname%" alt="%MAKETEXT{"Remove members..."}%" title="%MAKETEXT{"Remove members..."}%" class="jqUIDialogLink {cache:false}">%MAKETEXT{"Remove members..."}%</a>'
then="%BR%%ICON{"userdelete"}% <a href=\"%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_remove;groupname=%groupname%\" alt=\"%MAKETEXT{"Remove members..."}%\" title=\"%MAKETEXT{"Remove members..."}%\" class=\"jqUIDialogLink {cache:false}\">%MAKETEXT{"Remove members..."}%</a>"
}%
%IF{
"$allowremove AND
istopic '%USERSWEB%.%groupname%' AND
not ( '%USERSWEB%.%groupname%'/preferences[name='VIEW_TEMPLATE'].value = 'GroupView' )
"
then='%BR%%ICON{"wrench" quote="\""}% <a href="%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_upgrade;groupname=%groupname%" alt="%MAKETEXT{"Upgrade group topic..."}%" title="%MAKETEXT{"Upgrade group topic..."}%" class="jqUIDialogLink {cache:false}">%MAKETEXT{"Upgrade group topic..."}%</a>'
then="%BR%%ICON{"wrench"}% <a href=\"%SCRIPTURL{view}%/%WEB%/%TOPIC%?skin=text;section=group_upgrade;groupname=%groupname%\" alt=\"%MAKETEXT{"Upgrade group topic..."}%\" title=\"%MAKETEXT{"Upgrade group topic..."}%\" class=\"jqUIDialogLink {cache:false}\">%MAKETEXT{"Upgrade group topic..."}%</a>"
}%
<!-- /changegroup -->%ENDSECTION{"changegroup"}%
</verbatim>
Expand Down

1 comment on commit e29ba86

@AnthonyH
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anybody with an older version of Foswiki (or an upgraded version that has retained an older copy of this file), I found I had to replace quote="\"" with quote="$quot" in order to see the userdelete and wrench icons.

Please sign in to comment.