buildkite-agent: 2.1.13 -> 2.6.6 #30614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pawelpacana |
dezgeg
reviewed
Oct 20, 2017
| @@ -20,6 +19,26 @@ in | |||
| services.buildkite-agent = { | |||
| enable = mkEnableOption "buildkite-agent"; | |||
|
|
|||
| package = mkOption { | |||
| default = pkgs.buildkite-agent.bin; | |||
|
@zimbatm, nice, are you using this CI? We are planning to soon. |
Build the package from source Re-organise the module a bit to allow custom version of the package
zimbatm
force-pushed
the
buildkite-agent-2.6.6
branch
from
13ebe82
to
1d5e3a6
Compare
|
@domenkozar just testing it out for now as I heard good things from a friend. So far I am impressed. |
|
I think it's ideal for impure use of hydra slaves. Need to write support for hydra to trigger buildkite build. |
domenkozar
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the package from source
Re-organise the module a bit to allow custom version of the package
Motivation for this change
upgrade
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)