Docs: don't link libs or types inside libs #5152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Oct 20, 2017
| @@ -113,6 +113,9 @@ class Crystal::Doc::Generator | |||
| return false if nodoc?(type) | |||
| return true if crystal_builtin?(type) | |||
|
|
|||
| # Don't include lib types or types inside a lib type | |||
| return false if type.is_a?(Crystal::LibType) || type.namespace.is_a?(LibType) | |||
There was a problem hiding this comment.
Can there be multiple levels of nesting inside lib types? Does this handle it?
There was a problem hiding this comment.
Nope, there's only one level of nesting. I thought about that too when writing that line :-)
RX14
approved these changes
Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3072