Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-wrapper: add --no-assert to skip assertExecutable() #30161

Closed
wants to merge 2 commits into from
Closed

make-wrapper: add --no-assert to skip assertExecutable() #30161

wants to merge 2 commits into from

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Oct 6, 2017

Motivation for this change

This allows to disable the assertion introduced in #24944.
The assertion prevents from wrapping a file that is not accessible in the sandbox, which is too restrictive for development environments, e.g. when wrapping a script that is somewhere in $HOME.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lheckemann
Copy link
Member

  • I'm not sure the name is ideal as it doesn't make it very clear what the flag changes
  • There is no way of wrapping a program with --add-flags --no-assert without also triggering the no-assert behaviour

Other than that, LGTM.

@steveej
Copy link
Contributor Author

steveej commented Oct 6, 2017

I'm not sure the name is ideal as it doesn't make it very clear what the flag changes

Suggestions welcome ;-)

There is no way of wrapping a program with --add-flags --no-assert without also triggering the no-assert behaviour

This is solvable but I'm not sure if it's worth the complexity. You'd have to postpone the assertExecution() call until all arguments have been evaluated.

@orivej orivej mentioned this pull request Dec 12, 2017
Draft
8 tasks
@Ericson2314 Ericson2314 changed the base branch from master to staging December 12, 2017 20:03
@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Are there any updates on this pull request, please?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@steveej
Copy link
Contributor Author

steveej commented Jun 11, 2020 •
edited

@mmahut I used a fork for a while and then the project which needed it got abandoned. If you care for this feature I'll rebase it and we can continue the discussions.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 11, 2020
@Ekleog
Copy link
Member

Ekleog commented Sep 13, 2020

Seeing as there's AFAIU no currently known need for this change, let's close this and people can still find it back in the PR logs if they need it too :)

@Ekleog Ekleog closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steveej @lheckemann @mmahut @Ekleog