Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for "complete" SFINAE checks #2934

Merged
merged 3 commits into from Oct 11, 2017
Merged

Remove the need for "complete" SFINAE checks #2934

merged 3 commits into from Oct 11, 2017

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Oct 6, 2017

Refactor "complete" SFINAE use cases to work with "lowest common denominator" SFINAE. Remove "complete" SFINAE checks. Flyby remove duplicated reserve_if_possible utility.

@Naios
Copy link
Contributor

Naios commented Oct 6, 2017

Looks good to me 👍

@hkaiser hkaiser added this to the 1.1.0 milestone Oct 6, 2017
hkaiser
hkaiser approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So using enable_if on a dummy argument is more 'compiler-friendly' than using it as a dummy template argument... Very nice catch!

@K-ballo
Copy link
Member Author

K-ballo commented Oct 6, 2017

So using enable_if on a dummy argument is more 'compiler-friendly' than using it as a dummy template argument...

For the case of competing overloads, yes. Note those enable_if were declaring non-type template arguments.

For the traditional use cases of enable_if it makes no difference, and the template argument approach is generally cleaner.

@hkaiser hkaiser merged commit 8397a95 into master Oct 11, 2017
@hkaiser hkaiser deleted the sfinae-expression-complete branch October 11, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: core type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-ballo @Naios @hkaiser