Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpa_supplicant: fixes for KRACK #30468

Closed
wants to merge 1 commit into from
Closed

wpa_supplicant: fixes for KRACK #30468

wants to merge 1 commit into from

Conversation

ArdaXi
Copy link
Contributor

@ArdaXi ArdaXi commented Oct 16, 2017 •
edited

Motivation for this change

This adds the patches provided by Mathy Vanhoef to mitigate KRACK.

See https://www.krackattacks.com/ and https://w1.fi/security/2017-1/wpa-packet-number-reuse-with-replayed-messages.txt for more info.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ArdaXi ArdaXi mentioned this pull request Oct 16, 2017
Closed
@7c6f434c
Copy link
Member

Maybe fetch the entire patchset (including attempts at hardening) from upstream git repo using fetchpatch?

@grahamc
Copy link
Member

grahamc commented Oct 16, 2017

Hi @ArdaXi, for patches like this we typically want to use fetchpatch instead of bringing the patches in to our repo. I've already made the change using fetchpatch, and will be pushing shortly. Thank you a lot for being on top of it, and getting these patches in so quickly!

@grahamc grahamc closed this Oct 16, 2017
@ArdaXi ArdaXi deleted the krack_supplicant branch October 16, 2017 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArdaXi @7c6f434c @grahamc