LB-212: Show MetaBrainz logo at listenbrainz footer #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwflory
approved these changes
Oct 16, 2017
paramsingh
changed the title
paramsingh
reviewed
Oct 17, 2017
There was a problem hiding this comment.
@kartikeyaSh Hey! So nice to see you working on LB! :)
This PR should probably be based off the production branch instead of master so that we can get this fix deployed as soon as possible. The production branch is the one we use for small and quick fixes while master is used for big new features etc.
|
LGTM otherwise |
|
@paramsingh thanks for the review. I've created a new PR for that |
|
Superseded by #276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.