display-managers: Import DBUS session bus address & Xauthority #30467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
display-managers-session/sessionvars
branch
from
3bf4c2c
to
4b7cbb5
Compare
Mic92
reviewed
Oct 17, 2017
| ${config.systemd.package}/bin/systemctl --user import-environment XAUTHORITY | ||
|
|
||
| # Tell systemd about the dbus session bus address. This is required by user units using the session bus. | ||
| ${config.systemd.package}/bin/systemctl --user import-environment DBUS_SESSION_BUS_ADDRESS |
There was a problem hiding this comment.
The following should be possible according to man page:
${config.systemd.package}/bin/systemctl --user import-environment DISPLAY XAUTHORITY DBUS_SESSION_BUS_ADDRESSThere was a problem hiding this comment.
Yes it's possible but I wanted it on multiple lines for better clarity and commenting why every variable is necessary. I did merge DISPLAY and XAUTHORITY on the same line since they are very closely related.
There was a problem hiding this comment.
I think it's more clear to have it on multiple lines but I'm OK with changing it to one.
adisbladis
force-pushed
the
display-managers-session/sessionvars
branch
from
4b7cbb5
to
6d28edd
Compare
…temd user session
adisbladis
force-pushed
the
display-managers-session/sessionvars
branch
from
6d28edd
to
40f402c
Compare
|
Also in 17.09 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Systemd user session depending on these variables are broken.
I was making my own unit that uses
notify-sendfromlibnotifythat didn't work as expected.Things done
build-use-sandboxinnix.confon non-NixOS)- [ ] macOS- [ ] other Linux distributionsnix-shell -p nox --run "nox-review wip"./result/bin/)