SOLR-3, SOLR-66: Bring event to current search parity #45
Conversation
samj1912
changed the title
sir/wscompat/convert.py
Outdated
| :type obj: :class:`mbdata.models.LinkAreaEvent` | ||
| """ | ||
| relation = models.relation(direction="backward", | ||
| type_=obj.link.link_type.name) |
There was a problem hiding this comment.
Shouldn't this also output type_id? I also wonder why convert_area_relation above doesn't output attributes, but this does.
There was a problem hiding this comment.
I dont see a type_id anywhere in the current search results - https://musicbrainz.org/ws/2/event?query=area:Berlin
There was a problem hiding this comment.
Although I can see it has been added in ws results.
There was a problem hiding this comment.
Similarly the area-area rels do not have an attribute list in the current code https://github.com/metabrainz/search-server/blob/master/index/src/main/java/org/musicbrainz/search/index/AreaIndex.java#L232
There was a problem hiding this comment.
Not sure if there are tickets for that, but it should be made to match the standard WS results. Relationships should be serialized in the same way everywhere, other than the target entity -- I think it'd make sense to only have one method for serializing all relationships that accepts a callback to add in the target.
No description provided.