Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phantomjs2: add qtbase's bin to PATH #30036

Merged
merged 1 commit into from Oct 2, 2017
Merged

phantomjs2: add qtbase's bin to PATH #30036

merged 1 commit into from Oct 2, 2017

Conversation

alicebob
Copy link
Contributor

@alicebob alicebob commented Oct 2, 2017 •
edited

Motivation for this change

Phantomjs2 fails to load within selenium, as reported in #29144

This aplies the fix proposed by @7c6f434c in that ticket.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@alicebob
Copy link
Contributor Author

alicebob commented Oct 2, 2017

(push -f to fix commit message)

@alicebob alicebob changed the title add qtbase's bin path to phatomjs2 phantomjs2: add qtbase's bin to PATH Oct 2, 2017
@orivej orivej merged commit dd02fae into NixOS:master Oct 2, 2017
@orivej orivej mentioned this pull request Oct 2, 2017
Closed
@alicebob alicebob deleted the phantomjs2 branch October 3, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alicebob @orivej