Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citrix-receiver: 13.4.0 -> 13.7.0 #30029

Merged
merged 1 commit into from Oct 13, 2017
Merged

Conversation

jensbin
Copy link
Contributor

@jensbin jensbin commented Oct 2, 2017

Motivation for this change

New Citrix receiver release. The last two releases has caused issues in different environments, hope this is working again. It does for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm requested a review from obadz October 3, 2017 11:44
@Mic92 Mic92 merged commit 2820830 into NixOS:master Oct 13, 2017
@jensbin jensbin deleted the citrix_receiver_13.7.0 branch October 13, 2017 22:04
@obadz
Copy link
Contributor

obadz commented Oct 23, 2017

Sorry for the delay. This still doesn't work for me. @jensbin, did you have the error with 13.5 and 13.6 but not 13.7? Or did you never encounter the error described in https://discussions.citrix.com/topic/385459-ssl-error-with-135-works-with-134/?p=1977735 ?

Anyway, I'll refactor so version can be passed by arg.

@obadz
Copy link
Contributor

obadz commented Oct 23, 2017

Done in 26122b3

obadz added a commit that referenced this pull request Oct 23, 2017
Version 13.4.0 is the latest version that doesn't suffer from the bug
described at
https://discussions.citrix.com/topic/385459-ssl-error-with-135-works-with-134/page-2#entry1977735

As a result, upgrades to 13.5.0, 13.6.0 and 13.7.0 were postponed.
However some users aren't affected by this big. This enables everyone to
download the version that suits their needs.

Related to: #23975, #27664, #30029
@obadz
Copy link
Contributor

obadz commented Oct 23, 2017

@jensbin / @neilmayhew, could you give a try to the above commit? If it works for you, I'll cherry-pick it to 17.09.

@jensbin
Copy link
Contributor Author

jensbin commented Oct 23, 2017

Thanks @obadz, looks good to me!

I had issues with 13.5.0, but these were the "no keyboard issue". 13.6.0 and 13.7.0 working for me. Never faced the SSL issue with recent versions.

obadz added a commit that referenced this pull request Oct 24, 2017
Version 13.4.0 is the latest version that doesn't suffer from the bug
described at
https://discussions.citrix.com/topic/385459-ssl-error-with-135-works-with-134/page-2#entry1977735

As a result, upgrades to 13.5.0, 13.6.0 and 13.7.0 were postponed.
However some users aren't affected by this big. This enables everyone to
download the version that suits their needs.

Related to: #23975, #27664, #30029

(cherry picked from commit 26122b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants