pykms: init at 20170719 and corresponding NixOS module #30050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Oct 3, 2017
| propagatedBuildInputs = with python2Packages; [ argparse pytz ]; | ||
|
|
||
| prePatch = '' | ||
| siteDir=$(toPythonPath $out) |
There was a problem hiding this comment.
siteDir=$out/${python.sitePackages} ?
There was a problem hiding this comment.
For the record, I have no issue at all with your version but I'm genuinely curious about the reason.
There was a problem hiding this comment.
I personally prefer to use Nix as much as possible. This is also more common I think.
| homepage = "https://forums.mydigitallife.info/threads/50234-Emulated-KMS-Servers-on-non-Windows-platforms/page2?p=840410&viewfull=1#post840410"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ peterhoeg ]; | ||
| platforms = platforms.unix; |
akaWolf
suggested changes
Oct 11, 2017
|
All, thanks for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Have been running it here for testing purposes on 17.03 and 17.09 without problems.
While it works, I don't feel particularly proud of how the binaries are being wrapped as well as the handling of the DB creation script, so I'm very open to feedback on that.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)