Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More elegant test output #1588

Merged
merged 1 commit into from Oct 3, 2017
Merged

More elegant test output #1588

merged 1 commit into from Oct 3, 2017

Conversation

copumpkin
Copy link
Member

@copumpkin copumpkin commented Oct 3, 2017

I got sick of trying to find the failures in the sea of debug output, so we now:

  • Hide test output unless it fails
  • Sprinkle in some simple color if we're in a terminal that supports it (so Hydra/CI doesn't get cluttered up with escape codes)
  • Pad results for a more tabular look

If Nix is getting a more friendly user interface, we might as well get a friendlier developer interface, right? :)

I realize we don't want to add a dependency on a third-party test framework so I figured a few lines of make/bash could make this a lot more pleasant to work with.

Fixes #880

cc @edolstra @domenkozar @shlevy

I got sick of trying to find the failures in the sea of debug output, so
we now:
- Hide test output unless it fails
- Sprinkle in some simple color
- Pad results for a more tabular look

If Nix is getting a more friendly user interface, we might as well get
a friendlier developer interface, right? :)
Copy link
Member

@shlevy shlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@domenkozar
Copy link
Member

Ideally we'd a sample of output, but looks good! :)

@edolstra edolstra merged commit 60ecbd7 into NixOS:master Oct 3, 2017
@edolstra
Copy link
Member

edolstra commented Oct 3, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented Oct 6, 2017

this broke nix-build -A deb_ubuntu1604x86_64 release.nix:

GEN    tests/common.sh
/bin/sh: 7: tput: not found
/bin/sh: 8: [[: not found
/bin/sh: 16: Bad substitution

@Mic92
Copy link
Member

Mic92 commented Oct 6, 2017

#1593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants