Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade of enpass, from 5.4 to 5.6. #30046

Closed
wants to merge 1 commit into from

Conversation

cyraxjoe
Copy link
Contributor

@cyraxjoe cyraxjoe commented Oct 3, 2017

The file was generated with the update script that is part
of the nix expressions for enpass.

Motivation for this change

It seems that 5.4 has some issues with the dropbox sync, this was the original rationale to look for a newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The file was generated with the update script that is part
of the nix expressions for enpass.

Also, it seems that 5.4 has some issues with dropbox sync,
this was the original rationale to look for a newer version.
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

The commit message does not fit https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@cyraxjoe
Copy link
Contributor Author

cyraxjoe commented Oct 5, 2017

Yes I realize afterwards. I tought that wasn't a big deal, but better close this PR. I'll open a new one with the correct commit message when I have a chance.

@cyraxjoe cyraxjoe closed this Oct 5, 2017
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

OK. You could have used git commit --amend and git push --force to modify this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants