Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poppler: add nss to allow for building pdfsig #30037

Merged
merged 1 commit into from Jun 2, 2018
Merged

poppler: add nss to allow for building pdfsig #30037

merged 1 commit into from Jun 2, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Oct 2, 2017 •
edited

Motivation for this change

Poppler_tools contains a very useful tool to check the digital signatures of PDF files (pdfsig).
This tool was not being built, due to the absence of nss as a dependency. This is added as an optional dependency, so that the tool is built and people can happily check PDF signatures on the command line.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@leenaars
Copy link
Contributor Author

I don't see what the CI failure has to do with my (very simple) commit. One additional optional dependency is added, which allows the pdfsig tool to be built.

@globin
Copy link
Member

globin commented Jan 9, 2018

@GrahamcOfBorg eval

@jtojnar
Copy link
Contributor

jtojnar commented Jun 2, 2018

@GrahamcOfBorg build poppler_utils

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

gzipping man pages under /nix/store/5nbpjp9rr2kr9ic0lc0yj7nzwncwgwwc-poppler-utils-0.65.0/share/man/
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5nbpjp9rr2kr9ic0lc0yj7nzwncwgwwc-poppler-utils-0.65.0/lib  /nix/store/5nbpjp9rr2kr9ic0lc0yj7nzwncwgwwc-poppler-utils-0.65.0/bin
patching script interpreter paths in /nix/store/5nbpjp9rr2kr9ic0lc0yj7nzwncwgwwc-poppler-utils-0.65.0
checking for references to /build in /nix/store/5nbpjp9rr2kr9ic0lc0yj7nzwncwgwwc-poppler-utils-0.65.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/a7viyr2qfv5mcm2bl21q3nkqlx6k8ja4-poppler-utils-0.65.0-dev
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a7viyr2qfv5mcm2bl21q3nkqlx6k8ja4-poppler-utils-0.65.0-dev/lib
patching script interpreter paths in /nix/store/a7viyr2qfv5mcm2bl21q3nkqlx6k8ja4-poppler-utils-0.65.0-dev
checking for references to /build in /nix/store/a7viyr2qfv5mcm2bl21q3nkqlx6k8ja4-poppler-utils-0.65.0-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: poppler_utils

Partial log (click to expand)

strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g7kvppp5h63r5mql6x27sbqw4faanv6h-poppler-utils-0.65.0/lib  /nix/store/g7kvppp5h63r5mql6x27sbqw4faanv6h-poppler-utils-0.65.0/bin
patching script interpreter paths in /nix/store/g7kvppp5h63r5mql6x27sbqw4faanv6h-poppler-utils-0.65.0
checking for references to /build in /nix/store/g7kvppp5h63r5mql6x27sbqw4faanv6h-poppler-utils-0.65.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/pad1jljg07pifxv7bh4wnh2f7nm31aqn-poppler-utils-0.65.0-dev
strip is /nix/store/8yfik687kfccisxnad42j19lfb7ij9b4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pad1jljg07pifxv7bh4wnh2f7nm31aqn-poppler-utils-0.65.0-dev/lib
patching script interpreter paths in /nix/store/pad1jljg07pifxv7bh4wnh2f7nm31aqn-poppler-utils-0.65.0-dev
checking for references to /build in /nix/store/pad1jljg07pifxv7bh4wnh2f7nm31aqn-poppler-utils-0.65.0-dev...
/nix/store/g7kvppp5h63r5mql6x27sbqw4faanv6h-poppler-utils-0.65.0

@jtojnar jtojnar merged commit 56a9ab5 into NixOS:master Jun 2, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: poppler_utils

Partial log (click to expand)

../utils/pdfsig.cc:107:63: error: use of undeclared identifier 'basename'
    GooString *path = GooString::format(format->getCString(), basename(filename), sig_num);
                                                              ^
1 error generated.
[160/219] Linking CXX executable utils/pdffonts
[161/219] Building CXX object utils/CMakeFiles/pdfdetach.dir/parseargs.cc.o
[162/219] Building CXX object utils/CMakeFiles/pdfunite.dir/pdfunite.cc.o
ninja: build stopped: subcommand failed.
builder for '/nix/store/l2yly51v9sy53ncmfi33x7ix4zrm01n6-poppler-utils-0.65.0.drv' failed with exit code 1
error: build of '/nix/store/l2yly51v9sy53ncmfi33x7ix4zrm01n6-poppler-utils-0.65.0.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Jun 2, 2018

Reported the darwin failure upstream: https://bugs.freedesktop.org/show_bug.cgi?id=106783

@jtojnar jtojnar mentioned this pull request Jun 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @globin @jtojnar @GrahamcOfBorg