Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: init at 0.3.1 #30108

Merged
merged 1 commit into from Oct 6, 2017
Merged

dep: init at 0.3.1 #30108

merged 1 commit into from Oct 6, 2017

Conversation

carlsverre
Copy link
Contributor

@carlsverre carlsverre commented Oct 5, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

homepage = https://github.com/golang/dep;
maintainers = [ maintainers.carlsverre ];
platforms = platforms.linux;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the license: license = licenses.bsd3;

@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

We should compile it from source. It doesn't even have any dependencies, which makes it trivial to write the expression by hand, without go2nix

@carlsverre
Copy link
Contributor Author

Switching it to be from source now.

@orivej
Copy link
Contributor

orivej commented Oct 6, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants