Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: download source over https #30122

Merged
merged 1 commit into from Oct 5, 2017
Merged

llvm: download source over https #30122

merged 1 commit into from Oct 5, 2017

Conversation

phi-gamma
Copy link
Contributor

The source distribution contains binaries (probably for testing) that
make the Avira virus scanner treat it as malware on account of a “bad
ELF header”. Apart from being preferable in general, the HTTPS download
makes the file opaque to the overeager AV scanner in transparent
proxying setups.

Also adapt to the fact that the canonical downloads now point to a URL
like this:

https://releases.llvm.org/4.0.1/llvm-4.0.1.src.tar.xz
Motivation for this change

Download broken over virus scanning proxy (Avira). HTTPS can’t be scanned transparently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

The source distribution contains binaries (probably for testing) that
make the Avira virus scanner treat it as malware on account of a “bad
ELF header”. Apart from being preferable in general, the HTTPS download
makes the file opaque to the overeager AV scanner in transparent
proxying setups.

Also adapt to the fact that the canonical downloads now point to a URL
like this:

    https://releases.llvm.org/4.0.1/llvm-4.0.1.src.tar.xz
@orivej orivej changed the base branch from master to staging October 5, 2017 10:35
@orivej orivej requested review from LnL7 and vcunat October 5, 2017 10:38
@joachifm
Copy link
Contributor

joachifm commented Oct 5, 2017

I'd expect no rebuilds for this since the drv is fixed-output.

@orivej orivej changed the base branch from staging to master October 5, 2017 12:58
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

@joachifm Right.

@orivej orivej merged commit 109acb1 into NixOS:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants