Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connman: do not restart after suspend #30124

Merged
merged 1 commit into from Oct 13, 2017
Merged

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Oct 5, 2017

Motivation for this change

This causes connman to not reconnect after suspend on every third try or so. While this hack might be required for certain configurations, it should not be imposed on all Connman users, and when it's required it's certainly a bug that should be reported upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej requested a review from matejc October 5, 2017 20:59
@fpletz fpletz merged commit 22505d8 into NixOS:master Oct 13, 2017
@lukateras lukateras deleted the patch-1 branch December 18, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants