-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can not require openssl with JDK9 #4805
Comments
Also running into this problem when building the documentation for JUnit 5 on JDK-9 using Stacktrace:
|
Update: the error only occurs, when the pdf backend renderer is active. |
* Use --release 8 option from JDK 9 javac * Remove matrix and special java options from Travis CI The JUnit 5 build requires JDK-9 or higher. The JUnit 5 runtime environment needs to be Java 8 or higher. Travis CI now sets "-Xmx" by default. * Switch Javadoc step to use JDK 9 * Switch AsciiDoc step to use JDK 9 w/o PDF backend See jruby/jruby#4805 * Fix Clover instrumentation * Add custom AppVeyor script to install JDK-9 * Add JDK9-compatible Javadoc stylesheet * Fix Javadoc @value tag usages
This has been fixed in jruby/jruby-openssl@f86bc0b. It will be included in JRuby 9.1.14. |
The underlying issue jruby/jruby#4805 was solved and shipped in the already integrated JRuby 9.1.14 release. Closes #1099
We are still seeing this issue with 9.1.14 and the PDF backend of AsciiDoctorJ on Linux: https://junit.ci.cloudbees.com/blue/organizations/jenkins/JUnit5/detail/master/100/pipeline |
@sormuras any chance you give a few lines on how to trigger this broken pipeline locally ? |
On a Windows 10 box, a PDF is generated at: |
The log https://junit.ci.cloudbees.com/blue/organizations/jenkins/JUnit5/detail/pdf/1/pipeline shows:
Mh, maybe the build still uses the Is there debug switch I can set on start up to emit the jruby version? |
but a look at the |
Was this released? The same invocation with 9.1.15.0 triggers the same error.
|
A bit late, but here are the relevant
|
@sormuras there is clearly a |
Aye. But I thought we override via:
https://github.com/junit-team/junit5/blob/master/documentation/documentation.gradle Not? |
@sormuras your gradle config needs a little patch for asciidoctor picking the right jruby version: diff --git a/documentation/documentation.gradle b/documentation/documentation.gradle
index 1cf2676532..8698d2531d 100644
--- a/documentation/documentation.gradle
+++ b/documentation/documentation.gradle
@@ -2,7 +2,6 @@ buildscript {
dependencies {
// upgrade to latest jruby version due to a bugfix needed for Windows 10.
// can be removed, when asciidoctorj uses this as a default version.
- classpath('org.jruby:jruby-complete:9.1.15.0')
// classpath('org.asciidoctor:asciidoctorj-epub3:1.5.0-alpha.16')
classpath('org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16')
@@ -35,6 +34,7 @@ test {
*/
dependencies {
+ asciidoctor('org.jruby:jruby-complete:9.1.15.0')
testImplementation(project(':junit-jupiter-api'))
testImplementation(project(path: ':junit-jupiter-params', configuration: 'shadow'))
testImplementation(project(':junit-platform-runner')) |
Will give it shot. Thanks for the hint. |
Without the When adding the
|
This still only happens when the |
As suggested here: jruby/jruby#4805 (comment)
As suggested here: jruby/jruby#4805 (comment)
The relevant dependency tree now looks like:
|
As suggested here: jruby/jruby#4805 (comment)
* Use --release 8 option from JDK 9 javac * Remove matrix and special java options from Travis CI The JUnit 5 build requires JDK-9 or higher. The JUnit 5 runtime environment needs to be Java 8 or higher. Travis CI now sets "-Xmx" by default. * Switch Javadoc step to use JDK 9 * Switch AsciiDoc step to use JDK 9 w/o PDF backend See jruby/jruby#4805 * Fix Clover instrumentation * Add custom AppVeyor script to install JDK-9 * Add JDK9-compatible Javadoc stylesheet * Fix Javadoc @value tag usages
The underlying issue jruby/jruby#4805 was solved and shipped in the already integrated JRuby 9.1.14 release. Closes junit-team#1099
As suggested here: jruby/jruby#4805 (comment)
reproduce:
The text was updated successfully, but these errors were encountered: