Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wine update #30125

Merged
merged 2 commits into from Oct 5, 2017
Merged

Wine update #30125

merged 2 commits into from Oct 5, 2017

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Oct 5, 2017

Motivation for this change

Update wine unstable/staging to recent versions.
Unbreak build, broken by samba3 security assertion

Note: only 32bit build tested

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@avnik
wine: replace samba3 with samba4
0317d5d 
Unbreak security assertion via samba3 which no more supported.
@avnik
wineUnstable: 2.17 -> 2.18
8c34112 
Staging updated as well
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

Thank you!

@orivej orivej merged commit ac9550d into NixOS:master Oct 5, 2017
@roastiek
Copy link
Contributor

Could someone cherry pick wine: replace samba3 with samba4 into nixos-17.09. Without it, the wineStaging package is not even building on hydra.

@avnik
Copy link
Contributor Author

avnik commented Nov 12, 2017

@deedrah Don't sure, if wineStaging costs to build on hydra for stable. It updates biweekly (usually) and only in master. Not sure if staging build from month or two ago can be useful.

@grahamc
Copy link
Member

grahamc commented Nov 26, 2017

I backported the samba3/samba4 bit to 17.09: eb08538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avnik @orivej @roastiek @grahamc