Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avian: add meta.maintainers #30697

Merged
merged 1 commit into from Oct 24, 2017
Merged

avian: add meta.maintainers #30697

merged 1 commit into from Oct 24, 2017

Conversation

earldouglas
Copy link
Member

Motivation for this change

Improve maintainability by assigning a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Oct 22, 2017
View reviewed changes
pkgs/development/compilers/avian/default.nix Outdated
@@ -1,4 +1,4 @@
{ stdenv, fetchFromGitHub, zlib, jdk }:
{ stdenv, fetchFromGitHub, zlib, jdk, lib }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib is also available as stdenv.lib

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joachifm joachifm merged commit 6a65235 into NixOS:master Oct 24, 2017
@earldouglas earldouglas deleted the avian-maintainers branch October 24, 2017 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@earldouglas @joachifm