Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picat: add meta.maintainers #30699

Merged
merged 1 commit into from Oct 24, 2017
Merged

picat: add meta.maintainers #30699

merged 1 commit into from Oct 24, 2017

Conversation

earldouglas
Copy link
Member

@earldouglas earldouglas commented Oct 22, 2017 •
edited

Motivation for this change

Improve maintainability by assigning a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 23c8e96 into NixOS:master Oct 24, 2017
@joachifm
Copy link
Contributor

Thank you

@earldouglas earldouglas deleted the picat-maintainers branch October 24, 2017 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@earldouglas @joachifm