coqPackages.QuickChick: remove support for coq 8.7 #30708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rename the subject of the issue and the commit message to: "coqPackages.QuickChick: remove support for coq 8.7"? Otherwise, if upstream doesn't support 8.7, I don't see any reason to not commit this. |
maximedenes
changed the title
coqPackages_8_7.QuickChick won't build since Coq 8.7.0 is not yet supported upstream.
maximedenes
force-pushed
the
fix-quickchick
branch
from
799d7db
to
41df85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coqPackages_8_7.QuickChick won't build since Coq 8.7.0 is not yet supported
upstream.
Motivation for this change
I'm working upstream on the port of QuickChick to Coq 8.7.0, and I don't see how a Coq 8.7.0 derivation for QuickChick could be ready before that is done. In fact, even some dependencies don't build (it would require #30690).
I'm a proud Nix newbie, so I don't know what the usual practice is, but I find it strange to push untested (and broken) packages that don't even rely on a released version. Sorry to moan, but as an upstream author, I'm not happy to see my software packaged in such state.