Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcap: already patch Make.Rules in prePatch #30695

Merged
merged 1 commit into from Oct 25, 2017
Merged

libcap: already patch Make.Rules in prePatch #30695

merged 1 commit into from Oct 25, 2017

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Oct 22, 2017

Make.Rules gets already included during compilation, so set paths before
invoking make. This fixes wrong paths in libcap.pc.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@flokli
libcap: already patch Make.Rules in prePatch
a505abc 
Make.Rules gets already included during compilation, so set paths before
invoking make. This fixes wrong paths in libcap.pc.
@grahamc
Copy link
Member

grahamc commented Oct 24, 2017 •
edited

Seems minor

@Mic92 Mic92 merged commit f3a2570 into NixOS:staging Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg approved these changes

Assignees
No one assigned
Labels
1.severity: mass-rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flokli @grahamc @GrahamcOfBorg @joachifm @Mic92