A function to compute the downsampling error #1613
Conversation
eggrobin
force-pushed
the
downsampling-algorithm
branch
from
6407b92 to
322e3c3
Compare
geometry/named_quantities.hpp
Outdated
| struct Normed : base::not_constructible { | ||
| using NormType = T; | ||
| static NormType Norm(T const& vector) { | ||
| return quantities::Abs(vector); |
There was a problem hiding this comment.
Please move the method implementations to the body file.
There was a problem hiding this comment.
I don't know to write the definitions out of line with this fancy specialization.
There was a problem hiding this comment.
geometry/named_quantities.hpp
Outdated
| : base::not_constructible { | ||
| using NormType = decltype(std::declval<T>().Norm()); | ||
| static NormType Norm(T const& vector) { | ||
| return vector.Norm(); |
| // Returns the largest error (in the given |norm|) between this polynomial and | ||
| // the given |samples|. | ||
| template<typename Samples, typename GetArgument, typename GetValue> | ||
| typename Normed<Difference<Value>>::NormType LInfinityError( |
There was a problem hiding this comment.
Would the infinity symbol work in an identifier?
There was a problem hiding this comment.
No, we had the same issue with InfinitePast and InfiniteFuture.
numerics/hermite3_body.hpp
Outdated
| typename Normed<Difference<Value>>::NormType | ||
| Hermite3<Argument, Value>::LInfinityError(Samples const& samples, | ||
| GetArgument get_argument, | ||
| GetValue get_value) const { |
There was a problem hiding this comment.
Pass the functors by reference, you are not moving them.
| @@ -82,5 +95,50 @@ TEST_F(Hermite3Test, Conditioning) { | |||
| h.EvaluateDerivative(t0_ + 19418861.806896236 * Second)); | |||
| } | |||
|
|
|||
| TEST_F(Hermite3Test, OneDimensionalInterpolationError) { | |||
| std::vector<std::pair<double, double>> samples; | |||
| for (double i = 2; i < 10; i += 1) { | |||
numerics/hermite3_test.cpp
Outdated
| AngularFrequency const ω = 1 * Radian / Second; | ||
| for (Instant t = t0_; t <= tmax; t += 1 / 32.0 * Second) { | ||
| samples.push_back( | ||
| {t, World::origin + Displacement<World>({Cos(ω * (t - t0_)) * Metre, |
numerics/hermite3_test.cpp
Outdated
| EXPECT_THAT( | ||
| not_a_quartic.LInfinityError( | ||
| samples, | ||
| /*get_argument=*/[](auto&& pair) -> auto&& { return pair.first; }, |
numerics/hermite3_test.cpp
Outdated
| /*get_value=*/[](auto&& pair) -> auto&& { return pair.second; }), | ||
| AllOf(Gt(1 * Centi(Metre)), Lt(2 * Centi(Metre)))); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we have a test with a quartic?
There was a problem hiding this comment.
We do (it's the one above), but perhaps I shouldn't call the function that tries to match a circle not_a_quartic... :-p
|
This is part of the work on #228. |
Doing it in numerics, so fairly heavy templatization.