fetchgit: Remove incomplete/unneeded ref check.

This check fails for tags and branches, and is made redundant by the checks git itself will do when fetching the repo.
NixOS · Oct 17, 2017 · cbc2169 · cbc2169
1 parent 8522db1
commit cbc2169
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/src/libexpr/primops/fetchgit.cc b/src/libexpr/primops/fetchgit.cc
@@ -19,11 +19,6 @@ Path exportGit(ref<Store> store, const std::string & uri,
             throw Error("invalid Git revision '%s'", rev);
     }
 
-    // FIXME: too restrictive, but better safe than sorry.
-    std::regex refRegex("^[0-9a-zA-Z][0-9a-zA-Z.-]+$");
-    if (!std::regex_match(ref, refRegex))
-        throw Error("invalid Git ref '%s'", ref);
-
     Path cacheDir = getCacheDir() + "/nix/git";
 
     if (!pathExists(cacheDir)) {