Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: add 17.10.0-ce #30522

Merged
merged 1 commit into from Oct 19, 2017
Merged

docker: add 17.10.0-ce #30522

merged 1 commit into from Oct 19, 2017

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Oct 17, 2017 •
edited

Motivation for this change

New edge version.

  • 17.06 is now out of its support window, so removed
  • the preBuild optional is now always necessary
  • they changed the directory structure, so there is an if towards that
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 18, 2017
@NeQuissimus NeQuissimus requested review from FRidh, LnL7 and orivej and removed request for FRidh October 18, 2017 12:25
@NeQuissimus NeQuissimus changed the title [WIP] docker: add 17.10.0-ce docker: add 17.10.0-ce Oct 18, 2017
@FRidh FRidh removed their request for review October 18, 2017 12:27
@NeQuissimus NeQuissimus merged commit 606487e into NixOS:master Oct 19, 2017
@NeQuissimus NeQuissimus deleted the docker_17_10 branch October 19, 2017 11:39
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@orivej orivej Awaiting requested review from orivej

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @samueldr