switch ShellLauncher to use getAbsolutePath #4821
Closed
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the CI build failed in a bunch of places that are unrelated to my change, and it was also failing to build before my change. what do you need from me to look at this? |
|
+1 I don't use busybox, but we do this same exact fix for a symlinking problem at my company. |
|
sounds like, this makes sense - maybe even to get into 9.1.14.0 |
|
I'll merge this to 9.1.14 and master. Thanks for the help @zendes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues with using JRuby on a system that uses busybox as it's userland, and without this patch things won't work.
For a bit of background: busybox's goal is to be a tiny userland (commands like ls and mv) for space-constrained devices. One of the ways it does this is by being a multi-call binary. You symlink it with names such as ls and cp, and it uses $0 to determine how it's called and thus what it should do. JRuby resolves the symlink before it execs, so busybox loses $0 and thus doesn't know what the user originally called. This patch fixes that.