Ensure flight planner is always (partially) visible #1611
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Oct 17, 2017
There was a problem hiding this comment.
Thank you very much for the pull request; a couple of nitpicks, but this looks good.
In the future it might make sense to move some of that logic into a class used for all windows, but that would in any case be a job for a later pull request in a cleanup-oriented lunation.
ksp_plugin_adapter/flight_planner.cs
Outdated
| const float min_width_on_screen = 50; | ||
| const float min_height_on_screen = 50; | ||
| window_rectangle_.x = UnityEngine.Mathf.Clamp(window_rectangle_.x, | ||
| min_width_on_screen - window_rectangle_.width, |
There was a problem hiding this comment.
We use 80 character lines, please fold.
I'm also going ask you to put the all the min_something on the same side, I find that easier to understand:
window_rectangle_.x =
UnityEngine.Mathf.Clamp(
window_rectangle_.x,
-window_rectangle_.width + min_width_on_screen,
UnityEngine.Screen.width - min_width_on_screen);
window_rectangle_.y =
UnityEngine.Mathf.Clamp(
window_rectangle_.y,
-window_rectangle_.height + min_height_on_screen,
UnityEngine.Screen.height - min_height_on_screen);
should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609.