Skip to content

Commit f843b78

Browse files
author
Mehdi Abaakouk
committedNov 15, 2016
Add aliases for direct publisher
Deprecate the direct publisher in favor of explicit publisher name like 'gnocchi://', 'database://', 'file://', ... Change-Id: I11991352e55c7efc2fa808d429075a060fdcd29e
1 parent 7ff3ee4 commit f843b78

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed
 

‎ceilometer/publisher/direct.py

+9-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from stevedore import driver
1818
import stevedore.exception
1919

20-
from ceilometer.i18n import _LE
20+
from ceilometer.i18n import _LE, _LW
2121
from ceilometer import publisher
2222
from ceilometer.publisher import utils
2323

@@ -37,8 +37,15 @@ class DirectPublisher(publisher.ConfigPublisherBase):
3737
"""
3838
def __init__(self, conf, parsed_url):
3939
super(DirectPublisher, self).__init__(conf, parsed_url)
40+
default_dispatcher = parsed_url.scheme
41+
if default_dispatcher == 'direct':
42+
LOG.warning(_LW('Direct publisher is deprecated for removal. Use '
43+
'an explicit publisher instead, e.g. "gnocchi", '
44+
'"database", "file", ...'))
45+
default_dispatcher = 'database'
4046
options = urlparse.parse_qs(parsed_url.query)
41-
self.dispatcher_name = options.get('dispatcher', ['database'])[-1]
47+
self.dispatcher_name = options.get('dispatcher',
48+
[default_dispatcher])[-1]
4249
self._sample_dispatcher = None
4350
self._event_dispatcher = None
4451

‎setup.cfg

+8
Original file line numberDiff line numberDiff line change
@@ -245,13 +245,21 @@ ceilometer.publisher =
245245
direct = ceilometer.publisher.direct:DirectPublisher
246246
kafka = ceilometer.publisher.kafka_broker:KafkaBrokerPublisher
247247
http = ceilometer.publisher.http:HttpPublisher
248+
gnocchi = ceilometer.publisher.direct:DirectPublisher
249+
database = ceilometer.publisher.direct:DirectPublisher
250+
file_alt = ceilometer.publisher.direct:DirectPublisher
251+
http_alt = ceilometer.publisher.direct:DirectPublisher
248252

249253
ceilometer.event.publisher =
250254
test = ceilometer.publisher.test:TestPublisher
251255
direct = ceilometer.publisher.direct:DirectPublisher
252256
notifier = ceilometer.publisher.messaging:EventNotifierPublisher
253257
kafka = ceilometer.publisher.kafka_broker:KafkaBrokerPublisher
254258
http = ceilometer.publisher.http:HttpPublisher
259+
gnocchi = ceilometer.publisher.direct:DirectPublisher
260+
database = ceilometer.publisher.direct:DirectPublisher
261+
file_alt = ceilometer.publisher.direct:DirectPublisher
262+
http_alt = ceilometer.publisher.direct:DirectPublisher
255263

256264
ceilometer.event.trait_plugin =
257265
split = ceilometer.event.trait_plugins:SplitterTraitPlugin

0 commit comments

Comments
 (0)
Please sign in to comment.