Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devpi-client: 2.7.0 -> 3.1.0rc1 #30082

Merged
merged 2 commits into from Oct 5, 2017
Merged

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Oct 4, 2017

Motivation for this change

update devpi-client to the latest version.
With this commit i also bump the version of devpi-common from 3.0.1 -> 3.2.0rc1 and enable tests for the package.
Right now we cannot enable devpi-client tests because the devpi-server package is not yet packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@makefu makefu requested a review from FRidh as a code owner October 4, 2017 12:44
@orivej orivej merged commit 0eb0a40 into NixOS:master Oct 5, 2017
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

Apparently these rcs are quite stable and upstream is not going to release versions without rc soon.

@makefu
Copy link
Contributor Author

makefu commented Oct 5, 2017

@orivej i chose the rc because in the latest "stable" release the tests broke ...

@vcunat
Copy link
Member

vcunat commented Oct 5, 2017

meta didn't evaluate this way; fixed in 623df97.

@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

@vcunat Thank you! I'm working on automating such basic sanity checks of the PRs that is lighter weight than nox-review.

@vcunat
Copy link
Member

vcunat commented Oct 5, 2017

For a quick test I'm using

nix-env -f . -qaP --meta --json --drv-path --show-trace >/dev/null

It might be also nice to run something like

./maintainers/scripts/rebuild-amount.sh $(git merge-base HEAD master)

@makefu
Copy link
Contributor Author

makefu commented Oct 5, 2017

could we add this to travis-ci instead of it trying to build the whole thing from master? 👍
in the meantime i will add the quick check to my workflow

@vcunat
Copy link
Member

vcunat commented Oct 5, 2017

(well, hijacking this thread :-/) My vision would be to attempt to rebuild the changes only if there are a few of them. Another thing is that to most people it's not obvious at all whether a change is a mass rebuild (and thus whether it should go to staging instead).

@makefu
Copy link
Contributor Author

makefu commented Oct 5, 2017

@vcunat how about having multiple build steps for all these things, like:

  • sanity check (packages evaluate)
  • meta check (meta evaluates)
  • mass rebuild check (will build more than 100 packages)

When we see which test fails it would actually help the maintainers getting a quick overview about the state of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants