Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode: change UnicodeData.txt to stable version #30076

Merged
merged 1 commit into from Oct 4, 2017

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Oct 4, 2017

latest final release of Unicode is 10.0.0. 11.0.0 is not yet released.

Motivation for this change

see #29891 (review)

I think it is better not to depend on not-yet-released Unicode data. I guess this file will be renamed UnicodeData.txt in the future, and this URL will break.
@xzfc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

latest final release of Unicode is 10.0.0. 11.0.0 is not yet released.
@orivej orivej merged commit b182015 into NixOS:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants