Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin-classic: build with qt5 #30075

Closed
wants to merge 1 commit into from
Closed

bitcoin-classic: build with qt5 #30075

wants to merge 1 commit into from

Conversation

Lassulus
Copy link
Member

@Lassulus Lassulus commented Oct 4, 2017

Motivation for this change

using qt5 for bitcoin-classic

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Oct 4, 2017

I think you should use libsForQt5 as documented in the manual https://nixos.org/nixpkgs/manual/#ssec-qt-applications , but I don't know why, so I've asked here: #23239 (comment)

@Mic92 Mic92 closed this in 9c5ef04 Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lassulus @orivej