Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate-power-manager: init at 1.18.0 #30079

Merged
merged 1 commit into from Oct 12, 2017
Merged

Conversation

chpatrick
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

homepage = http://mate-desktop.org;
license = licenses.gpl3;
platforms = platforms.unix;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A maintainer must be set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I put myself or @romildo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the one who adds a package ends up also being the initial maintainer since they've expressed interest in using the package at least for the near future. But either works or you peeps can obviously both be maintainers too. 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chpatrick It is up to you. If you want to be a maintainer just put yourself. I can also be a maintainer. Both of us can be maintainers.

@Mic92 Mic92 changed the title Add mate-power-manager. mate-power-manager: init at 1.18.0 Oct 4, 2017
@orivej
Copy link
Contributor

orivej commented Oct 5, 2017

The commit message must also be reworded: please read CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 7, 2017

cc @romildo for review.

@chpatrick
Copy link
Contributor Author

Hi, can this be merged?

@Mic92 Mic92 merged commit 8bff56c into NixOS:master Oct 12, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants