New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mate-power-manager: init at 1.18.0 #30079
Conversation
homepage = http://mate-desktop.org; | ||
license = licenses.gpl3; | ||
platforms = platforms.unix; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A maintainer must be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I put myself or @romildo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the one who adds a package ends up also being the initial maintainer since they've expressed interest in using the package at least for the near future. But either works or you peeps can obviously both be maintainers too. 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chpatrick It is up to you. If you want to be a maintainer just put yourself. I can also be a maintainer. Both of us can be maintainers.
The commit message must also be reworded: please read CONTRIBUTING.md. |
cc @romildo for review. |
8d839f8
to
c5a8998
Compare
c5a8998
to
5f23a1b
Compare
5f23a1b
to
e3675fe
Compare
Hi, can this be merged? |
Thanks! |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)